Implement using WPR namespace for all service variables #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solovyovk
approved these changes
Jul 9, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
solovyovk
reviewed
Jul 16, 2025
There was a problem hiding this comment.
The Kubernetes manifest examples need to be updated to use the appropriate WProofreader image version.
Since this release introduces major, non-backward-compatible changes, the Chart version(version: 1.2.0) must be promoted and the corresponding image version(appVersion: "5.39.1.0") set in the Chart.yaml file.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the WProofreader Helm chart to use the new WPR namespace prefix for all service environment variables, along with version updates to chart 1.3.0 and app version 6.2.0.0.
- Updates all environment variable names from generic names to WPR-prefixed names (e.g.,
PROTOCOL→WPR_PROTOCOL) - Updates chart version from 1.2.0 to 1.3.0 and app version from 5.39.1.0 to 6.2.0.0
- Updates documentation and comments to reflect the new variable naming convention
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| wproofreader/values.yaml | Updates comments to reference new WPR-prefixed variable names and example environment variable |
| wproofreader/templates/deployment.yaml | Changes environment variable names to use WPR prefix in deployment template |
| wproofreader/Chart.yaml | Bumps chart version to 1.3.0 and app version to 6.2.0.0 |
| manifests/*.yaml | Updates version labels and Docker image tag across all manifest files |
| README.md | Updates documentation to reference new WPR_LICENSE_TICKET_ID variable name |
solovyovk
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.